Re: [PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.

[Carlos O'Donell <carlos at redhat dot com>]

On 10/30/2017 04:51 PM, Rafal Luzynski wrote:
> 27.10.2017 18:02 Carlos O'Donell <carlos@redhat.com> wrote:
>> [...]
>> As subsystem maintainer for localedata you do not need review. You can assume
>> consensus and fix the file directly.
>>
>> You are correct that the category lines are in error, they should be removed,
>> I didn't notice them in my final regeneration.
>>
>> However! The category line generated by
>> localedata/unicode-gen/gen_unicode_ctype.py
>> is also wrong.
> 
> So this time it was worth to wait for your review.

We are in development mode, and so incremental progress towards fixing
these issues is acceptable. I would have been just as happy with two
commits. My goal is to make your day-to-day volunteers hours as
productive as possible, and if you can commit your incremental change,
that has value to everyone else also.

>> It is a static 'unicode:2014', and this is invalid.
>>
>> ISO 30112 standard defines the valid values for the category.
>>
>> There are only 4 valid values:
>> "i18n:2012"
>> "i18n:2004"
>> "posix:1993"
>> and they state the conformance of the category itself.
>>
>> Next step:
>>
>> * Remove the category entries in i18n_ctype except for LC_CTYPE.
>> * Adjust the category entry for LC_CTYPE to use "i18n:2012"
>> * Adjust gen_unicode_ctype.py to output "i18n:2012" instead of the invalid
>> "unicode:2014"
> 
> Done.
> 
>> We should make localedef validate the conformance of this value, but that's
>> another patch.
> 
> OK, indeed it's another patch so I did not implement this.
> 
>> I will assume you will make the changes unless you hand them off to me.
> 
> Please see the attachment.

LGTM.

For ChangeLog would just say:

	* localedata/unicode-gen/gen_unicode_ctype.py (output_head):
	category of LC_CTYPE set to "i18n:2012".
	* localedata/locales/i18n_ctype: Regenerate.

Note: "category" on line 2 need not line up with "localedata", and
      for a regenerated file we just say "Regenerate."

-- 
Cheers,
Carlos.