This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] resolv: Remove bogus targets that build ga_test
On 10/19/2017 10:21 PM, hawkinsw@borlaugic.com wrote:
> Per Mr. O'Donell's suggestion/feedback, I am sending a v2 of this very
> simple patch that will remove the resolv/ga_test target and also remove the
> resolv/ga_test.c source file.
>
> Again, I am trying to follow all the rules for the proper formatting
> of patches and I hope that I did it correctly. Please let me know if
> I did not.
>
> Thanks again for all the work that everyone does for the community!
>
> Will
>
> --- commit msg:
> Remove the bogus targets (and source) that supposedly build ga_test.
> This code was added to resolv very early in the development process
> but does not appear to be an actual test program. The target for
> building this file is tests but because the glibc Make system is
> built the way it is, the target is overriden by higher-level tests
> targets and, therefore, the ga_test program is never built. Removing
> the target and the source code makes the resolv/Makefile less confusing.
>
> Tested by building and running 'make check' on 64 bit host running
> Kernel 4.10.0-19 configured with
> --prefix=/home/hawkinsw/code/glibc-build/install
> --enable-hardcoded-path-in-tests
> --disable-mathvec
> ---
>
> 2017-10-13 Will Hawkins <hawkinsw@borlaugic.com>
>
> * resolv/Makefile: Remove bogus targets that build resolv/ga_test
> and resolv/ga_test.c itself.
Looks good to me!
Testing was clean.
I've committed this for you.
I rewrote your ChangeLog entry, to focus on what was being changed,
and used some [] to denote context () to denote which target was
changed, and listed the removed file. Don't worry too much about it,
sometimes copying examples is the best way to write one.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.