This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/5] Fix deadlock in _int_free consistency check


On 10/12/2017 11:35 PM, Wilco Dijkstra wrote:
I suppose we could also print the error once at the end:

if (error detected)
{
   bool fail = true;
   if (!have_lock)
   {
      get_lock
      fail = repeat test
      unlock
   }
   if (fail)
     print error
}

Yes, that's also a good option.

Anyway, should I make the one-character change removing the ! in the meantime? This is a real bug, and we should fix that even if the code still isn't as pretty as it could be.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]