Re: [PATCH] Benchtests for sinf, cosf and sincosf

[Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>]

On 10/11/2017 12:05 PM, Siddhesh Poyarekar wrote:
> On Tuesday 10 October 2017 09:36 PM, Rajalakshmi Srinivasaraghavan wrote:
> > Numbers used from cos and sin inputs.
> >
> > 2017-10-10  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>
> >
> > 	* benchtests/Makefile (bench-math):  Add sinf, cosf and sincosf.
> > 	* benchtests/sincosf-inputs: New file.
> > 	* benchtests/cosf-inputs: New file.
> > 	* benchtests/sinf-inputs: New file.
>
> I think we need an include mechanisms for these files now, where you
> could just do something like:
>
> ##include-inputs: sin
>
> instead of copying the exact same set of inputs.  There seem to be more
> than a couple of near-identical copies of such inputs now and that's an
> unnecessary waste of space.

Yes, we can try that next where we can keep inputs in a common
data file and convert it based on expected argument type
like float/double.

> Siddhesh

--
Thanks
Rajalakshmi S