This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 05/58] Mark internal argp functions with attribute_hidden [BZ #18822]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: libc-alpha at sourceware dot org
- Date: Sun, 1 Oct 2017 14:42:48 -0700
- Subject: Re: [PATCH 05/58] Mark internal argp functions with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-6-hjl.tools@gmail.com>
On 9/1/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> Mark internal argp functions with attribute_hidden to allow direct
> access to them within libc.so and libc.a without using GOT nor PLT.
>
> [BZ #18822]
> * argp/argp-fmtstream.c: Include <argp-fmtstream.h>.
> * argp/argp-fs-xinl.c: Likewise.
> * argp/argp-help.c: Include <argp.h> and <argp-fmtstream.h>.
> * argp/argp-parse.c: Include <argp.h>.
> * argp/argp-xinl.c: Likewise.
> * include/argp-fmtstream.h: New file.
> * include/argp.h (__argp_error): Add attribute_hidden.
> (__argp_failure): Likewise.
> (__argp_input): Likewise.
> (__argp_state_help): Likewise.
Tested with build-many-glibcs.py. I am checking it in.
--
H.J.