This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited 4/4] hurd: Fix `getifaddrs' and `freeifaddrs' symbol exposition
Hello,
H.J. Lu, on mer. 27 sept. 2017 17:21:40 -0700, wrote:
> On 9/27/17, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > from `freeaddrinfo'.
> >
> > `getifaddrs' and `freeifaddrs' are not in POSIX, they should not be
> > exposed along `freeaddrinfo' (through `__check_pf') which is POSIX.
> >
> > * include/ifaddrs.h (__getifaddrs, __freeifaddrs): New declarations,
> > and use libc_hidden_def on them.
> > * inet/ifaddrs.c (__getifaddrs, __freeifaddrs): Use libc_hidden_def on
> > them.
> > * sysdeps/gnu/ifaddrs.c (__getifaddrs, __freeifaddrs): Likewise.
> > * inet/check_pf.c (__check_pf): Use __getifaddrs and __freeifaddrs
> > instead of getifaddrs and freeifaddrs.
> >
>
> I checked in this patch to fix Linux build.
>
> ../sysdeps/unix/sysv/linux/ifaddrs.c:835:27: error: ‘getifaddrs’ aliased to undefined symbol ‘__getifaddrs’
> weak_alias (__getifaddrs, getifaddrs)
> ^
> ../sysdeps/unix/sysv/linux/ifaddrs.c:844:28: error: ‘freeifaddrs’ aliased to undefined symbol ‘__freeifaddrs’
> weak_alias (__freeifaddrs, freeifaddrs)
>
> caused by
>
> commit 4009ddc69225d571772aaea597615a0c032e14ab
Oh, sorry, I missed that the mere addition of libc_hidden_proto would
change the needs of other archs.
Thanks,
Samuel