Re: Remove non-add-on Banner files

[Carlos O'Donell <carlos at redhat dot com>]

On 09/21/2017 10:56 AM, Joseph Myers wrote:
> Various subdirectories of glibc include Banner files to put some text
> in the output of executing libc.so.6, under "Available extensions".
> 
> Some of those subdirectories (e.g. crypt) may originally have been
> add-ons (and so optional, so a particular glibc build might or might
> not have included them), but except for libidn they aren't now (or if
> only included in some builds, in the case of soft-fp, the inclusion
> depends on the architecture for which glibc is configured rather than
> having any glibc configuration for which it's an optional feature),
> and it doesn't seem useful for the libc.so.6 output to call out a few
> features like that.
> 
> This patch removes the non-add-on Banner files, updating contrib.texi
> where they noted contributions not otherwise mentioned there.
> 
> Tested for x86_64.
> 
> I think it also makes sense to remove the libidn Banner file and the
> whole Banner mechanism (there are plenty of configuration choices not
> mentioned in the libc.so.6 output, why should this one be special?),
> and, independently, to remove the whole add-ons mechanism and just
> build libidn via Subdirs.
> 
> 2017-09-21  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* crypt/Banner: Remove file.
> 	* nptl/Banner: Likewise.
> 	* resolv/Banner: Likewise.
> 	* soft-fp/Banner: Likewise.
> 	* nptl/Makefile ($(objpfx)banner.h): Remove rule.
> 	($(objpfx)version.d): Remove dependency on banner.h.
> 	($(objpfx)version.os): Likewise.
> 	* nptl/version.c (banner): Do not include banner.h.
> 	* manual/contrib.texi: Update entries for Richard Henderson, Jakub
> 	Jelinek and BIND code.

Reviewed-by: Carlos O'Donll <carlos@redhat.com>

-- 
Cheers,
Carlos.