This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libio: Assume _LIBC, weak_alias, errno, (__set_)errno &c are defined


On 08/31/2017 02:30 PM, Zack Weinberg wrote:
> On Thu, Aug 31, 2017 at 8:14 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> libio lives exclusively in glibc these days, so there is no reason to
>> preserve _LIBC conditionals.
>>
>> While at it, I also removed some unnecessary indirections and conditions
>> on other always-defined macros (F_GETFL, EIO, etc.).
>>
>> I checked that this does not change the produced binaries on i686.
> 
> LGTM.
> 
> If you're in a mood to clean up libio, may I suggest going after
> _IO_MTSAFE_IO next? ;-)

After internal_function perhaps.  _IO_MTSAFE_IO is quite hard because
it's not consistently defined across glibc.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]