This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][AArch64] Fix elf_greg_t on ILP32
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com
- Date: Tue, 29 Aug 2017 16:00:38 +0100
- Subject: Re: [PATCH][AArch64] Fix elf_greg_t on ILP32
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <599DB988.7040501@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 23/08/17 18:21, Szabolcs Nagy wrote:
> Use uint64_t instead of unsigned long.
>
> will commit it tomorrow if there are no objections.
>
> ChangleLog:
> 2017-08-23 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/unix/sysv/linux/aarch64/sys/procfs.h (elf_greg_t):
> Use uint64_t instead of unsigned long.
>
hm sys/procfs.h is included into signal.h
via sys/ucontext.h, where stdint.h should
not be exposed..
this does not happen in standards conforming
mode, but happens with _DEFAULT_SOURCE==1 so
it may cause problems.
i'm not sure if this is ok or better use
unsigned long long instead of uint64_t
(preferred uint64_t to avoid changing the
type on lp64)