This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] assert: Suppress pedantic warning caused by statement expression [BZ# 21242]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Date: Thu, 10 Aug 2017 22:28:35 +0000
- Subject: Re: [PATCH] assert: Suppress pedantic warning caused by statement expression [BZ# 21242]
- Authentication-results: sourceware.org; auth=none
- References: <6619e7e2-248e-08bc-6dc5-7b4d11bea3df@auburn.edu> <925e8a81-86f9-78a6-1578-660c04e39e3c@redhat.com> <alpine.DEB.2.20.1703211617300.8480@digraph.polyomino.org.uk> <b3e54310-9e08-c0fb-b0ee-b2a07711ef9a@redhat.com> <alpine.DEB.2.20.1706261055440.21187@digraph.polyomino.org.uk> <b50d764b-0616-855d-8359-a34d1210acfd@redhat.com> <a26386c3-7c12-be12-14f4-4d3ca7930452@redhat.com> <CAKCAbMjD4rkFo6CL4WGbL9T0ZUenBY_7KCUb_MRYGAEyPejWLQ@mail.gmail.com> <b94daa92-b63c-04df-89d9-0267a0299e23@redhat.com> <CAKCAbMjcNDvvp7-rSr2-yxG0UVha6K-QXU-LMSuS0kaLkBW+9g@mail.gmail.com> <7635632a-e375-ea34-fe4f-19cd08262ce1@redhat.com> <8d08346f-28e9-a106-c743-959eab49b429@redhat.com> <CAKCAbMi1+u3MH_xGDUyEF2e7QuC33hjHwKLu1LDmgvEQwv141A@mail.gmail.com>
On Thu, 10 Aug 2017, Zack Weinberg wrote:
> On Thu, Aug 10, 2017 at 11:32 AM, Florian Weimer <fweimer@redhat.com> wrote:
> > On 07/06/2017 11:50 AM, Florian Weimer wrote:
> >> assert: Suppress pedantic warning caused by statement expression
>
> Looks good to me except ...
>
> >> (__ASSERT_FUNCTION): Add missing __extendsion__.
>
> ... typo here: __extendsion__ should be __extension__.
>
> Might be good to confirm Joseph likes this version, tho.
I have no comments on this patch version.
--
Joseph S. Myers
joseph@codesourcery.com