This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo

From: Florian Weimer <fweimer at redhat dot com>
To: Samuel Thibault <samuel dot thibault at ens-lyon dot org>, libc-alpha at sourceware dot org
Date: Thu, 10 Aug 2017 15:28:05 +0200
Subject: Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 500D72A0DBE
References: <20170803002352.62vnzxfs7jnu236t@var.youpi.perso.aquilenet.fr> <20170803003626.zwmxsoskpoihgfzn@var.youpi.perso.aquilenet.fr> <20170803085418.gy5v5pk5h6jlcdhb@var.youpi.perso.aquilenet.fr> <128f21d2-6e76-feb8-5e85-a13feba1b51e@redhat.com>

On 08/03/2017 12:28 PM, Florian Weimer wrote:
> __inet6_scopeid_pton: Remove attribute_hidden, internal_function
> 
> The hidden attribute was overridden by libc_hidden_proto on GNU/Linux.
> It is incorrect because the function is used from nscd.
> 
> internal_function is not supposed to be used across DSO boundaries,
> so this commit removes it (again, due to the use in nscd).
> 
> 2017-08-03  Florian Weimer  <fweimer@redhat.com>
> 
> 	* inet/net-internal.h (__inet6_scopeid_pton): Remove
> 	attribute_hidden, internal_function.
> 	* inet/inet6_scopeid_pton.c (__inet6_scopeid_pton): Remove
> 	internal_function.

Any comments/  Otherwise I'm going to commit this shortly.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
  - From: Samuel Thibault

References:
- [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
  - From: Samuel Thibault
- Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
  - From: Samuel Thibault
- Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
  - From: Samuel Thibault
- Re: [PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]