This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Removed redundant data for LC_MONETARY
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 10 Aug 2017 12:14:59 +0200
- Subject: Re: [PATCH v3] Removed redundant data for LC_MONETARY
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 45339C07F983
- References: <CGME20170809130144epcas5p390741db9c51a1b094f92e6cae528b888@epcas5p3.samsung.com> <1502283434-48227-1-git-send-email-akhilesh.k@samsung.com> <s9defsjpzxa.fsf@redhat.com>
Mike FABIAN <mfabian@redhat.com> wrote:
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>> Reference is taken from
>> https://en.wikipedia.org/wiki/Indian_numbering_system
>> https://en.wikipedia.org/wiki/Indian_rupee
>>
>> [BZ #21836]
>
> [...]
>
>> diff --git a/localedata/locales/hi_IN b/localedata/locales/hi_IN
>> index 05b8918..1841201 100644
>> --- a/localedata/locales/hi_IN
>> +++ b/localedata/locales/hi_IN
>> @@ -76,19 +76,21 @@ LC_MONETARY
>> % These are generated based on XML base Locale definition file
>> % for IBM Class for Unicode/Java
>> %
>> -int_curr_symbol "<U0049><U004E><U0052><U0020>"
>> +int_curr_symbol "INR "
>> currency_symbol "<U20B9>"
>> -mon_decimal_point "<U002E>"
>> -mon_thousands_sep "<U002C>"
>> -mon_grouping 3
>> +mon_decimal_point "."
>> +mon_thousands_sep ","
>> +% https://en.wikipedia.org/wiki/Indian_numbering_system
>> +mon_grouping 2,3
>
> anp_IN.UTF-8..../locales/hi_IN:84: LC_MONETARY: syntax error
> LC_MONETARY: field `mon_grouping' not defined
Reading https://en.wikipedia.org/wiki/Indian_numbering_system
I also think you have the order wrong, it should be:
mon_grouping 3;2
Because that would give you the formats:
"INR12,34,567.89", "₹12,34,567.89"
"-INR12,34,567.89", "-₹12,34,567.89"
Which seems to be what Wikipedia describes.
--
Mike FABIAN <mfabian@redhat.com>