This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Added New Locale en_SC
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 04 Aug 2017 10:39:37 +0200
- Subject: Re: [PATCH 1/1] Added New Locale en_SC
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2F8281241
- References: <CGME20170728053957epcas5p2fd5b86e08dddf391e78fcffeb9a443a3@epcas5p2.samsung.com> <1501220154-33298-1-git-send-email-akhilesh.k@samsung.com>
Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> New locale is added for Seychelles which is a member of the African
> Union and Official languages is English
>
> [#BZ 21854]
> * localedata/SUPPORTED : Added en_SC.UTF-8
> * localedata/locales/en_SC: Added New File en_SC
>
Looks mostly OK, I’ll commit that with the following changes:
diff --git a/localedata/locales/en_SC b/localedata/locales/en_SC
index 387f9ca7f3..49800a83fe 100644
--- a/localedata/locales/en_SC
+++ b/localedata/locales/en_SC
@@ -13,7 +13,7 @@ escape_char /
LC_IDENTIFICATION
title "English locale for the Seychelles"
-source "Samsung Electronics Co., Ltd."
+source "Samsung Electronics Co., Ltd."
Fix trailing whitespace
address ""
contact ""
email "akhilesh.k@samsung.com"
@@ -52,11 +52,11 @@ END LC_COLLATE
LC_MONETARY
int_curr_symbol "SCR "
currency_symbol "SR"
-mon_decimal_point "<U002E>"
-mon_thousands_sep "<U002C>"
+mon_decimal_point "."
+mon_thousands_sep ","
Make it more readable by using ASCII.
mon_grouping 3;3
positive_sign ""
-negative_sign "<U002D>"
+negative_sign "-"
Make it more readable by using ASCII.
int_frac_digits 2
frac_digits 2
p_cs_precedes 1
@@ -88,12 +88,10 @@ END LC_PAPER
LC_TELEPHONE
% https://www.howtocallabroad.com/seychelles/
-% +%c %l
-tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U006C>"
+tel_int_fmt "+%c %l"
Make it more readable by using ASCII.
% 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda
-int_select "<U0030><U0030>"
-% 248
-int_prefix "<U0032><U0034><U0038>"
+int_select "00"
+int_prefix "248"
Make it more readable by using ASCII.
END LC_TELEPHONE
LC_MEASUREMENT
@@ -106,14 +104,15 @@ END LC_NAME
LC_ADDRESS
postal_fmt "%f%N%h%s%N%T"
-country_name "seychelles"
+country_name "Seychelles"
In English, country names start with a capital letter.
country_ab2 "SC"
country_ab3 "SYC"
country_num 690
-country_car "SYC"
+% https://en.wikipedia.org/wiki/List_of_international_vehicle_registration_codes
+country_car "SY"
I think "SYC" was wrong.
country_isbn "978-99931"
% English
-lang_name "<U0045><U006E><U0067><U006C><U0069><U0073><U0068>"
+lang_name "English"
Make it more readable by using ASCII.
lang_ab "en"
lang_term "eng"
lang_lib "eng"
--
Mike FABIAN <mfabian@redhat.com>