This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] rtld: Reject overly long LD_AUDIT path elements


On Thu, Jun 29, 2017 at 4:36 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 06/29/2017 09:56 PM, Zack Weinberg wrote:
>>
>> I am not an experienced exploit writer either, and I don't know this
>> code at all, but as a matter of principle, I do not think you should
>> make any changes until Andreas actually explains his concerns in
>> _detail_.  One-sentence cryptic questions, at a rate of one per email,
>> are not proper code review.
>
> To be fair, the original patch went in without much review on
> libc-alpha, too.

Carlos made clear that he had, in fact, read the entire thing, and I
trust that if he had had concerns he would have said so.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]