This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 23 Jun 2017 23:13:06 +0200
- Subject: Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com ED901165ED3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ED901165ED3
- References: <20170623161158.GA5384@gmail.com> <ef60f811-b227-cbc0-a8d6-ba8c3c13ea82@redhat.com> <CAMe9rOryBUqXQgYU=0mzD=6GAvr=zJHLwDfd3XqaFpS8KL0CUw@mail.gmail.com>
On 06/23/2017 06:26 PM, H.J. Lu wrote:
>> Does this result in a visible difference for applications? If yes,
>> please file a bug for this and reference it in the ChangeLog and commit
>> message.
>
> It will be very hard to tell since these symbols were exported from libc.so
> by accident and we only keep them in libc.so for backward binary compatibility.
> Application can no longer reference them from libc.so.
Ah, it's the old <regexp.h> interface, and the symbols were exported
deliberately. We apparently do not have any tests for it.
> Here is the updated patch. OK for master?
Yes, please. Thanks.
Florian