This is the mail archive of the
mailing list for the glibc project.
Re: [RFC PATCH] Remove bits/string.h.
- From: Zack Weinberg <zackw at panix dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 20 Jun 2017 08:27:01 -0400
- Subject: Re: [RFC PATCH] Remove bits/string.h.
- Authentication-results: sourceware.org; auth=none
- References: <firstname.lastname@example.org>
On 06/12/2017 05:23 PM, Zack Weinberg wrote:
> We just got rid of the machine-independent string inlines in the
> headers (bits/string2.h) thanks to Wilco; I propose we also eliminate
> the machine-dependent ones (bits/string.h). These are not on by
> default, and even if they were a good idea at the time they were
> introduced, they haven't really been touched in ten to fifteen years
> and probably aren't a good idea on current-gen processors.
> With this patch applied, the only effect of __NO_STRING_INLINES is to
> disable the __stpcpy -> __builtin_stpcpy and
> __mempcpy -> __builtin_mempcpy redirects in include/string.h. I
> suspect this can be cleaned up further but I would like to see this
> patch stick first.
Wilco endorsed this and there have been no other comments in a week, so
I have gone ahead and pushed this. I will be alert for problems.