This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH 0/2] aarch64: Add optimized ASIMD versions of sinf/cosf
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: "Sekhar, Ashwin" <Ashwin dot Sekhar at cavium dot com>, "siddhesh at gotplt dot org" <siddhesh at gotplt dot org>, "adhemerval dot zanella at linaro dot org" <adhemerval dot zanella at linaro dot org>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>, Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- Date: Mon, 19 Jun 2017 11:46:41 +0000
- Subject: Re: [RFC][PATCH 0/2] aarch64: Add optimized ASIMD versions of sinf/cosf
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <VI1PR0802MB2621465F621A03FFA7C4607683C20@VI1PR0802MB2621.eurprd08.prod.outlook.com> <d201fdbb-5954-397e-8c08-e0c77b2417f0@linaro.org>,<1497623981.11152.19.camel@caviumnetworks.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Sekhar, Ashwin wrote:
>
> In my work, I only used algorithms that are already in libm in other
> architectures' sinf/cosf implementations. So I guess the issue
> that Szabolcs raised about math code licensing doesn't really apply to
> my patch??
Firstly the ARM and AArch64 optimized assembly routines are also in cortex-strings,
bionic and newlib, pretty much identically. Such patches have to be committed first
to cortex-strings or newlib to avoid licensing issues.
Similarly https://github.com/ARM-software/optimized-routines contains various
math functions which are faster than the ones in GLIBC.
And yes, your patches have licensing issues - since you have signed your copyright
away, neither of your patches can ever be used in other libraries. That makes it less
useful to add them to GLIBC as we'd have to create different versions for the other
libraries.
Wilco