This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Enable tunables by default
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org
- Cc: nd at arm dot com
- Date: Fri, 16 Jun 2017 17:12:43 +0100
- Subject: Re: [PATCH v2] Enable tunables by default
- Authentication-results: sourceware.org; auth=none
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <1497463683-18434-1-git-send-email-siddhesh@sourceware.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 14/06/17 19:08, Siddhesh Poyarekar wrote:
> All of the major architectures are adopting tunables as a way to add
> tuning to the library, from hwcap_mask for aarch64 to HLE for s390 and
> ifunc and cache geometry for x86. Given this adoption and the fact
> that we don't want additional tuning knobs to be added outside of
> tunables, it makes sense to enable tunables by default using this
> trivial patch.
>
> Smoke tested on x86 to ensure that tunables code was built without
> specifying it as a configure flag. I have kept it as --enabled and
> not changed it to --disable since we want to still keep the option of
> different kinds of front-ends for tunables.
>
> * configure.ac(--enable-tunables): Enable by default.
> * configure: Regenerate.
> * NEWS: Mention change.
> * manual/install.texi (enable-tunables): Adjust documentation.
> * INSTALL: Regenerate.
note that gen-tunables.awk does not work with gawk 3.1.8
because it uses multi-dimensional arrays
so this broke the build for me on x86.