This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 6/6] Deprecate xlocale.h and add bits/types/locale_t.h.
On Wed, 14 Jun 2017, Zack Weinberg wrote:
> On Wed, Jun 14, 2017 at 7:11 AM, Florian Weimer <email@example.com> wrote:
> > On 06/10/2017 07:17 PM, Zack Weinberg wrote:
> >> xlocale.h is already a single-type micro-header, defining locale_t, so
> >> it would be nice to bring it into the overall bits/types/ scheme.
> >> Unfortunately, it's in the top level of the system-header namespace
> >> and, despite the comment saying "This file is not standardized, don't
> >> rely on it, it can go away without warning", there are a lot of
> >> external uses, so we need to deprecate it first, which is what this
> >> patch does.
> > I would suggest to remove it outright. I saw quite a few references to
> > <xlocale.h> covered under autoconf tests. Removal means that the tests
> > fail, and the #include <xlocale.h> is #ifdef'ed out in the actual
> > sources. A deprecation warning will cause the autoconf test to fail,
> > but then the #include may still fail due to the deprecation warning and
> > -Werror.
> (I assume you meant "the autoconf test will succeed".)
> I'm willing to do that if there is general agreement but I'd like to
> hear from some more people first.
I'd be fine with getting rid of xlocale.h.
I think __locale_t may well be one of the many interfaces that need
providing under implementation-namespace names for libstdc++ headers to be
namespace-clean and not require _GNU_SOURCE to implement standard C++
functionality (but I haven't checked exactly how it's used in libstdc++).
Joseph S. Myers