This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 03/17] support: Add optstring support
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 13 Jun 2017 11:22:48 +0200
- Subject: Re: [PATCH 03/17] support: Add optstring support
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0131519D39D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0131519D39D
- References: <1496956411-25594-1-git-send-email-adhemerval.zanella@linaro.org> <1496956411-25594-4-git-send-email-adhemerval.zanella@linaro.org>
On 06/08/2017 11:13 PM, Adhemerval Zanella wrote:
> +#ifdef CMDLINE_OPTSTRING
> + test_config.optstring = CMDLINE_OPTSTRING;
> +#else
> + test_config.optstring = "+";
Why not "+" CMDLINE_OPTSTRING, for consistency?
Otherwise, this looks good to me.
Thanks,
Florian