This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/6] PowerPC64 FRAME_PARM_SAVE

From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
To: Alan Modra <amodra at gmail dot com>, libc-alpha at sourceware dot org
Cc:
Date: Mon, 12 Jun 2017 15:07:39 -0300
Subject: Re: [PATCH 2/6] PowerPC64 FRAME_PARM_SAVE
Authentication-results: sourceware.org; auth=none
References: <20170601130442.GF8842@bubble.grove.modra.org> <20170601130858.GH8842@bubble.grove.modra.org>

Alan Modra <amodra@gmail.com> writes:

> This is just a tidy.  I think FRAME_PARM[1-9]_SAVE confuse the code,
> particularly FRAME_PARM9_SAVE.  There are only 8 parameter save slots!
>
> 	* sysdeps/powerpc/powerpc64/sysdep.h: (FRAME_BACKCHAIN,
> 	FRAME_CR_SAVE, FRAME_LR_SAVE): Move out of conditional.
> 	(FRAME_PARM1_SAVE, FRAME_PARM2_SAVE, FRAME_PARM3_SAVE,
> 	FRAME_PARM4_SAVE, FRAME_PARM5_SAVE, FRAME_PARM6_SAVE,
> 	FRAME_PARM7_SAVE, FRAME_PARM8_SAVE, FRAME_PARM9_SAVE): Delete.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc64/makecontext.S: Replace
> 	uses of FRAME_PARM[1-9]_SAVE with FRAME_PARM_SAVE plus offset.

Looks good to me.

-- 
Tulio Magno

References:
- [PATCH 0/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY
  - From: Alan Modra
- [PATCH 2/6] PowerPC64 FRAME_PARM_SAVE
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]