This is the mail archive of the
mailing list for the glibc project.
Fix tst-timezone race (bug 14096)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 7 Jun 2017 16:07:45 +0000
- Subject: Fix tst-timezone race (bug 14096)
- Authentication-results: sourceware.org; auth=none
I observed a failure of timezone/tst-timezone with the same symptoms
as reported in bug 14096.
I was unable to reproduce the failure on testing again. However, from
inspection, the cause is as follows. tst-timezone uses time zones
compiled from the northamerica file, but has no dependency on any such
zones, so with a parallel build it is possible that they do not get
compiled until after tst-timezone is run. This patch adds a
dependency on the compiled America/New_York zone (the one used as a
makefile target to cause such zones to be compiled, rather than one
which is actually used in that test) to fix the race.
Tested for x86_64.
2017-06-07 Joseph Myers <firstname.lastname@example.org>
* timezone/Makefile ($(objpfx)tst-timezone.out): Depend on
diff --git a/timezone/Makefile b/timezone/Makefile
index ab9d55b..35e6a95 100644
@@ -79,6 +79,7 @@ $(objpfx)test-tz.out: $(addprefix $(testdata)/, America/New_York Etc/UTC UTC)
$(objpfx)tst-timezone.out: $(addprefix $(testdata)/, \
Europe/Berlin Universal \
+ America/New_York \
America/Sao_Paulo Asia/Tokyo \
$(objpfx)tst-tzset.out: $(addprefix $(testdata)/XT, 1 2 3 4)
Joseph S. Myers