This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 2 Jun 2017 16:05:17 +0200
- Subject: Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1033BC0587D3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1033BC0587D3
- References: <20170511100718.1F66A401E714A@oldenburg.str.redhat.com> <52802461-8188-52e7-eeba-9cdce0be340d@linaro.org>
On 06/02/2017 03:56 PM, Adhemerval Zanella wrote:
>> +static char *
>> +getcanonname (service_user *nip, struct gaih_addrtuple *at, const char *name)
>> +{
>> + return strdup (name);
>> +}
> I think you need to use __strdup here, I am seeing check-local-plt failures on
> master.
On which architecture? I don't get see it on x86-64.
I can push a fix blindly (based on the headers, it indeed needs to be
__strdup).
Thanks,
Florian