This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] fork: Remove bogus parent PID assertions [BZ #21386]
- From: fweimer at redhat dot com (Florian Weimer)
- To: libc-alpha at sourceware dot org
- Date: Fri, 12 May 2017 12:20:47 +0200
- Subject: [PATCH] fork: Remove bogus parent PID assertions [BZ #21386]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A5CF6804EF
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A5CF6804EF
2017-05-12 Florian Weimer <fweimer@redhat.com>
[BZ #21386]
* sysdeps/nptl/fork.c (__libc_fork): Remove assertions on the
parent PID. The assertion in the child is incorrect with PID
namespaces.
diff --git a/sysdeps/nptl/fork.c b/sysdeps/nptl/fork.c
index db6d721..4bb87e2 100644
--- a/sysdeps/nptl/fork.c
+++ b/sysdeps/nptl/fork.c
@@ -131,10 +131,6 @@ __libc_fork (void)
call_function_static_weak (__malloc_fork_lock_parent);
}
-#ifndef NDEBUG
- pid_t ppid = THREAD_GETMEM (THREAD_SELF, tid);
-#endif
-
#ifdef ARCH_FORK
pid = ARCH_FORK ();
#else
@@ -147,8 +143,6 @@ __libc_fork (void)
{
struct pthread *self = THREAD_SELF;
- assert (THREAD_GETMEM (self, tid) != ppid);
-
/* See __pthread_once. */
if (__fork_generation_pointer != NULL)
*__fork_generation_pointer += __PTHREAD_ONCE_FORK_GEN_INCR;
@@ -230,8 +224,6 @@ __libc_fork (void)
}
else
{
- assert (THREAD_GETMEM (THREAD_SELF, tid) == ppid);
-
/* Release acquired locks in the multi-threaded case. */
if (multiple_threads)
{