This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Remove the bulk of the NaCl port.


On 05/12/2017 02:37 AM, Zack Weinberg wrote:
	* NEWS: NaCl port has been removed.
	* abi-tags: Remove .*-.*-nacl.* entry.
	* sysdeps/arm/nacl: Remove directory and contents.
	* sysdeps/nacl: Likewise.

We don't reference NEWS updates in the ChangeLog.  You could use this:

	Remove the NaCl port.
	* abi-tags: Remove .*-.*-nacl.* entry.
	…

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch zack/scrap-nacl
# Changes to be committed:

Something went wrong there, I think.

The removal itself looks okay, assuming that the directory trees are indeed gone after the patch has been applied. I replicated this locally, and there aren't any nacl/ path references left afterwards, so this should not impact any other architecture.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]