This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add __BEGIN_DECLS and __END_DECLS for C++
On Thu, May 11, 2017 at 10:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 11, 2017 at 7:43 AM, Zack Weinberg <zackw@panix.com> wrote:
>>
>> This program does not appear to need ifunc-impl-list.h. Please elaborate.
>
> Please see hjl/x86/optimize branch in glibc git repo.
I don't especially appreciate being made to dig through a bunch of
code I'm unfamiliar with. It would have been easy for you to write
"The existing benchtests framework uses ifunc-impl-list.h to iterate
over all ifunc implementations of a particular string function. This
works as long as the test program is C, but I want to integrate a
third-party benchmark <url> written in C++, so I need to make
ifunc-impl-list.h C++-safe". If that had accompanied the original
patch it would have been better all around.
It looks to me as if IFUNC_IMPL_ADD is not C++-safe and cannot easily
be made so, so I don't like this change. What prevents you from
rewriting the third-party benchmark in C, since you have to modify it
anyway? It's not doing anything that is difficult in plain C.
zw