This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 05/10] Remove __need macros from errno.h (__need_Emath, __need_error_t).
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: <libc-alpha at sourceware dot org>, <adhemerval dot zanella at linaro dot org>, <Wilco dot Dijkstra at arm dot com>, <fweimer at redhat dot com>, <carlos at redhat dot com>, <schwab at suse dot de>
- Date: Tue, 9 May 2017 21:38:36 +0000
- Subject: Re: [PATCH 05/10] Remove __need macros from errno.h (__need_Emath, __need_error_t).
- Authentication-results: sourceware.org; auth=none
- References: <20170509154103.11973-1-zackw@panix.com> <20170509154103.11973-6-zackw@panix.com>
On Tue, 9 May 2017, Zack Weinberg wrote:
> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
> index 74f9a49b05..075c996f28 100644
> --- a/misc/sys/cdefs.h
> +++ b/misc/sys/cdefs.h
> @@ -326,6 +326,13 @@
> # define __attribute_artificial__ /* Ignore */
> #endif
>
> +/* Force use of the initial-exec TLS model. */
> +#if __GNUC_PREREQ (3,3)
> +# define __attribute_tls_model_ie__ __attribute__ ((tls_model ("initial-exec")))
This is not namespace-clean for an installed header (needs to be
__tls_model__).
This is not a review of the rest of this patch.
--
Joseph S. Myers
joseph@codesourcery.com