This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Migrate grp/gshadow/inet/nss/pwd/resolv/shadow tests to support test driver
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 4 May 2017 16:02:58 -0300
- Subject: Re: [PATCH] Migrate grp/gshadow/inet/nss/pwd/resolv/shadow tests to support test driver
- Authentication-results: sourceware.org; auth=none
- References: <1493142540-3354-1-git-send-email-wainersm@gmail.com>
On 25/04/2017 14:49, Wainer dos Santos Moschetta wrote:
> Updated all tests of grp, gshadow, inet, nss, pwd, resolv, and shadow
> to use the support test driver.
>
> Checked on x86_64-linux-gnu.
>
> 2017-04-25 Wainer dos Santos Moschetta <wainersm@gmail.com>
>
> * grp/tst-putgrent.c: Replace test-skeleton.c with support/test-driver.c
> and remove TEST_FUNCTION macro.
> * gshadow/tst-gshadow.c: Likewise.
> * gshadow/tst-putsgent.c: Likewise.
> * inet/bug-if1.c: Likewise.
> * inet/test-ifaddrs.c: Likewise.
> * inet/test-inet6_opt.c: Likewise.
> * inet/test_ifindex.c: Likewise.
> * inet/tst-ether_aton.c: Likewise.
> * inet/tst-ether_line.c: Likewise.
> * inet/tst-gethnm.c: Likewise.
> * inet/tst-getni1.c: Likewise.
> * inet/tst-getni2.c: Likewise.
> * inet/tst-inet6_rth.c: Likewise.
> * inet/tst-inet6_scopeid_pton.c: Likewise.
> * inet/tst-network.c: Likewise.
> * inet/tst-ntoa.c: Likewise.
> * inet/tst-sockaddr.c: Likewise.
> * nss/bug17079.c: Likewise.
> * nss/test-digits-dots.c: Likewise.
> * nss/test-netdb.c: Likewise.
> * nss/tst-field.c: Likewise.
> * nss/tst-nss-getpwent.c: Likewise.
> * nss/tst-nss-static.c: Likewise.
> * nss/tst-nss-test1.c: Likewise.
> * pwd/tst-getpw.c: Likewise.
> * pwd/tst-putpwent.c: Likewise.
> * resolv/tst-aton.c: Likewise.
> * resolv/tst-inet_ntop.c: Likewise.
> * resolv/tst-leaks.c: Likewise.
> * resolv/tst-leaks2.c: Likewise.
> * resolv/tst-res_hconf_reorder.c: Likewise.
> * shadow/tst-putspent.c: Likewise.
> * shadow/tst-shadow.c: Likewise.
LGTM with small request below.
> diff --git a/resolv/tst-leaks.c b/resolv/tst-leaks.c
> index 4f64535..c49d8c6 100644
> --- a/resolv/tst-leaks.c
> +++ b/resolv/tst-leaks.c
> @@ -21,15 +21,10 @@
> #include <resolv.h>
> #include <mcheck.h>
>
> -/* Prototype for our test function. */
> -extern int do_test (int argc, char *argv[]);
> -
> -/* This defines the `main' function and some more. */
> #define TIMEOUT 40
> -#include <test-skeleton.c>
>
> int
> -do_test (int argc, char *argv[])
> +do_test (void)
Since you are there, add static on do_test.