This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] nptl: Using libsupport for tst-cancel4*



On 01/05/2017 14:18, Florian Weimer wrote:
> On 04/27/2017 11:30 PM, Adhemerval Zanella wrote:
>>         r = pthread_barrier_wait (&b2);
>>         if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
>> -    {
>> -      printf ("%s: barrier_wait failed\n", __FUNCTION__);
>> -      exit (1);
>> -    }
>> +    FAIL_EXIT1 ("pthread_barrier_wait");
>>       }
> 
> Just a quick comment that we already have xpthread_barrier_wait and xmmap, so you could use them for error checking.  There are also strdup calls which should be xstrdup.

Right, I will change to use them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]