This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] nptl: Using libsupport for tst-cancel4*
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 1 May 2017 14:41:15 -0300
- Subject: Re: [PATCH 2/4] nptl: Using libsupport for tst-cancel4*
- Authentication-results: sourceware.org; auth=none
- References: <1493328657-8172-1-git-send-email-adhemerval.zanella@linaro.org> <1493328657-8172-2-git-send-email-adhemerval.zanella@linaro.org> <c244ad44-287d-0185-a5d2-23a6c2840fd5@redhat.com>
On 01/05/2017 14:18, Florian Weimer wrote:
> On 04/27/2017 11:30 PM, Adhemerval Zanella wrote:
>> r = pthread_barrier_wait (&b2);
>> if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
>> - {
>> - printf ("%s: barrier_wait failed\n", __FUNCTION__);
>> - exit (1);
>> - }
>> + FAIL_EXIT1 ("pthread_barrier_wait");
>> }
>
> Just a quick comment that we already have xpthread_barrier_wait and xmmap, so you could use them for error checking. There are also strdup calls which should be xstrdup.
Right, I will change to use them.