This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] posix: Implement preadv2 and pwritev2
On Fri, 28 Apr 2017, Adhemerval Zanella wrote:
> My objection to __ASSUME_* is it adds more different possible build modes
> which won't get actively tested unless you explicit adds a minimum kernel
> option on build time. And which different __ASSUME_* enabled by different
> kernel version it would require different build with multiple different
> enabled minimum kernel version to get all the coverage to check for all
> permutations. I think we can add an explicit comment and keep track based
> on this, since with minimum kernel increase it will be eventually dead code.
Well, such comments would all need to be in a central place (e.g.
kernel-features.h) identifying the relevant versions, not scattered across
the source tree.
--
Joseph S. Myers
joseph@codesourcery.com