This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [musl] [PATCH] add support for POSIX_SPAWN_SETSID
- From: Zack Weinberg <zackw at panix dot com>
- To: Rich Felker <dalias at libc dot org>
- Cc: musl at lists dot openwall dot com, GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 22 Apr 2017 19:43:01 -0400
- Subject: Re: [musl] [PATCH] add support for POSIX_SPAWN_SETSID
- Authentication-results: sourceware.org; auth=none
- References: <20170331050243.4485-1-quae@daurnimator.com> <20170331160156.GL17319@brightrain.aerifal.cx> <20170422231933.GK17319@brightrain.aerifal.cx>
On Sat, Apr 22, 2017 at 7:19 PM, Rich Felker <dalias@libc.org> wrote:
>> > #define POSIX_SPAWN_SETSIGMASK 8
>> > #define POSIX_SPAWN_SETSCHEDPARAM 16
>> > #define POSIX_SPAWN_SETSCHEDULER 32
>> > +#define POSIX_SPAWN_SETSID 64
>>
>> This overlaps with the glibc value for POSIX_SPAWN_USEVFORK; while we
>> don't implement it, we also don't want to have mismatched constant
>> ABI.
...
> Thanks for all your work on this! Based on the glibc patch review, I'm
> changing the error condition from !=0 to <0, and of course changing
> the flag value to 128 to match.
May I suggest that musl include a note in its headers, explaining that
bit 64 is reserved to avoid an ABI conflict with glibc? Then the next
time there's an addition, there will be less confusion.
zw