This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Add reallocarray function.
On 18.04.2017 17:50, Carlos O'Donell wrote:> My only remaining issue is
that the works you present are based on Sonderfeld's
> work, and should include his name in the ChangeLog to give credit for the basis
> of the work.
>
> e.g.
>
> 2017-04-17 Dennis Wölfing <denniswoelfing@gmx.de>
> Rüdiger Sonderfeld <ruediger@c-plusplus.de>
>
> * ...
>
The patch I have submitted already contains two separate ChangeLog entries:
2017-04-17 Dennis Wölfing <denniswoelfing@gmx.de>
* ...
2017-04-17 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
* malloc/Versions: Add reallocarray and __libc_reallocarray.
* malloc/Makefile (tests): Add tst-reallocarray.c.
* malloc/tst-reallocarray.c: New test file.
* malloc/malloc.h (reallocarray): New declaration.
* stdlib/stdlib.h (reallocarray): Likewise.
* malloc/malloc.c (check_mul_overflow): New inline function.
(__libc_reallocarray): New function.
(__libc_calloc): Use `check_mul_overflow'.
Should I merge these entries?