This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Remove socket.S implementation

On 05/21/2015 09:56 PM, Adhemerval Zanella wrote:

@@ -72,7 +76,7 @@ accept4 (int fd, __SOCKADDR_ARG addr, socklen_t *addr_len, int flags)
  	  /* Try another call, this time with the FLAGS parameter
  	     cleared and an invalid file descriptor.  This call will not
  	     cause any harm and it will return immediately.  */
-	  ret = __internal_accept4 (-1, addr, addr_len, 0);
+	  ret = SOCKETCALL_CANCEL (invalid, -1);


I doubt that this can compile. :-/
I propose to radically simplify this logic and simply require at least kernel version 3.2.18 on ia64, so that we always have either an accept4 system call or an accept4 socket call. I have something approaching a patch for that.
(accept4 support was backported to the 3.2 stable series on ia64 because it was realized that too much broke on ia64 due to the missing support.) 

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]