This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Assume that pipe2 is always available
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Thu, 13 Apr 2017 19:54:43 +0200
- Subject: Re: [PATCH] Assume that pipe2 is always available
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2BEAFC03BD5F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2BEAFC03BD5F
- References: <20170413153744.A69B2400F200A@oldenburg.str.redhat.com> <6c73f962-b1ee-2756-f073-a6304fa1a75a@linaro.org>
On 04/13/2017 07:39 PM, Adhemerval Zanella wrote:
On 13/04/2017 12:37, Florian Weimer wrote:
The Debian patches (which are already required to build glibc before
this commit) contain an implementation of pipe2.
I did not follow, which 'Debian patches' are you referring here?
Upstream master contains an incomplete implementation of O_CLOEXEC
support for Hurd. For example, the file sysdeps/mach/hurd/accept4.c
refers to the sock_to_o_flags identifier, but neither glibc, gnumach,
nor hurd contain a definition. The definition is found in a patch in
the Debian package. There is another patch which contains an
implementation of pipe2:
https://sources.debian.net/src/glibc/2.24-8/debian/patches/hurd-i386/tg-pipe2.diff/
Anyone who wants to build glibc for Hurd needs those Debian patches, so
I see no problem with applying this cleanup to upstream master.
(From the Hurd perspective. NaCl does not support pipe2, either.)
Thanks,
Florian