This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH v3] hppa: Use generic pthread conditional variable support (BZ #21016)


On 2017-04-01, at 10:01 AM, John David Anglin wrote:

> On 2017-03-12, at 10:58 AM, John David Anglin wrote:
> 
>> The attach change switches the hppa target to use the generic pthread conditional variable support.
>> We lose compatibility with linuxthreads but I don't think that is relevant anymore for the existing distributions.
>> 
>> The change fixes bug nptl/21016.
> 
> Here is an updated patch to switch hppa to generic pthread conditional variable support.

The previous version had a problem, namely the failure of nptl/tst-typesizes.  This was caused by an incorrect
size for the pthread_cond_t type.  The placement of "__attribute__ ((__aligned__(16)))" increased the size.

This is fixed revising the pthread_cond_t declaration.  New test results are below.  Most of the math fails have been
fixed by a regen of the ulps.

> 
> As noted by Aaro, the original patch didn't delete sysdeps/unix/sysv/linux/hppa/pthread_cond_init.c.  This
> is corrected here.  Otherwise, the patches are the same.
> 
> Retested last night on my tree with the following results:
> 
> FAIL: debug/tst-backtrace2
> FAIL: debug/tst-backtrace3
> FAIL: debug/tst-backtrace4
> FAIL: debug/tst-backtrace5
> FAIL: debug/tst-backtrace6
> FAIL: elf/check-execstack
> FAIL: elf/check-textrel
> FAIL: elf/tst-audit2
> FAIL: malloc/tst-malloc-thread-fail
> FAIL: malloc/tst-trim1
> FAIL: math/test-double-cacos
> FAIL: math/test-double-cacosh
> FAIL: math/test-double-canonicalize
> FAIL: math/test-double-casin
> FAIL: math/test-double-casinh
> FAIL: math/test-double-catan
> FAIL: math/test-double-catanh
> FAIL: math/test-double-finite-cacos
> FAIL: math/test-double-finite-cacosh
> FAIL: math/test-double-finite-casin
> FAIL: math/test-double-finite-casinh
> FAIL: math/test-double-finite-catan
> FAIL: math/test-double-finite-catanh
> FAIL: math/test-float-cacos
> FAIL: math/test-float-cacosh
> FAIL: math/test-float-canonicalize
> FAIL: math/test-float-casin
> FAIL: math/test-float-casinh
> FAIL: math/test-float-catan
> FAIL: math/test-float-catanh
> FAIL: math/test-float-finite-cacos
> FAIL: math/test-float-finite-cacosh
> FAIL: math/test-float-finite-casin
> FAIL: math/test-float-finite-casinh
> FAIL: math/test-float-finite-catan
> FAIL: math/test-float-finite-catanh
> FAIL: math/test-idouble-cacos
> FAIL: math/test-idouble-cacosh
> FAIL: math/test-idouble-canonicalize
> FAIL: math/test-idouble-casin
> FAIL: math/test-idouble-casinh
> FAIL: math/test-idouble-catan
> FAIL: math/test-idouble-catanh
> FAIL: math/test-ifloat-cacos
> FAIL: math/test-ifloat-cacosh
> FAIL: math/test-ifloat-canonicalize
> FAIL: math/test-ifloat-casin
> FAIL: math/test-ifloat-casinh
> FAIL: math/test-ifloat-catan
> FAIL: math/test-ifloat-catanh
> UNSUPPORTED: nptl/test-cond-printers
> UNSUPPORTED: nptl/test-condattr-printers
> UNSUPPORTED: nptl/test-mutex-printers
> UNSUPPORTED: nptl/test-mutexattr-printers
> UNSUPPORTED: nptl/test-rwlock-printers
> UNSUPPORTED: nptl/test-rwlockattr-printers
> FAIL: nptl/tst-cleanupx4
> FAIL: nptl/tst-cond25
> FAIL: nptl/tst-create-detached
> FAIL: nptl/tst-robust-fork
> FAIL: nptl/tst-rwlock19
> FAIL: nptl/tst-stack4
> FAIL: nptl/tst-typesizes
> FAIL: resolv/tst-resolv-basic
> FAIL: resolv/tst-resolv-search
> FAIL: stdlib/tst-setcontext2
> UNSUPPORTED: sunrpc/tst-svc_register
> FAIL: timezone/tst-tzset
> Summary of test results:
>     61 FAIL
>   3225 PASS
>      7 UNSUPPORTED
>     45 XFAIL


V3 results:

FAIL: debug/tst-backtrace2
FAIL: debug/tst-backtrace3
FAIL: debug/tst-backtrace4
FAIL: debug/tst-backtrace5
FAIL: debug/tst-backtrace6
FAIL: elf/check-execstack
FAIL: elf/check-textrel
FAIL: elf/tst-audit2
FAIL: malloc/tst-malloc-thread-fail
FAIL: malloc/tst-trim1
FAIL: math/test-double-canonicalize
FAIL: math/test-float-canonicalize
FAIL: math/test-idouble-canonicalize
FAIL: math/test-ifloat-canonicalize
UNSUPPORTED: nptl/test-cond-printers
UNSUPPORTED: nptl/test-condattr-printers
UNSUPPORTED: nptl/test-mutex-printers
UNSUPPORTED: nptl/test-mutexattr-printers
UNSUPPORTED: nptl/test-rwlock-printers
UNSUPPORTED: nptl/test-rwlockattr-printers
FAIL: nptl/tst-cleanupx4
FAIL: nptl/tst-cond25
FAIL: nptl/tst-create-detached
FAIL: nptl/tst-robust-fork
FAIL: nptl/tst-rwlock19
FAIL: resolv/tst-resolv-basic
FAIL: resolv/tst-resolv-search
FAIL: stdlib/tst-setcontext2
FAIL: timezone/tst-tzset
Summary of test results:
     23 FAIL
   3267 PASS
      6 UNSUPPORTED
     45 XFAIL

Dave
--
John David Anglin	dave.anglin@bell.net


Attachment: pthread_cond-v3.d.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]