This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] S390: Use generic spinlock code.
- From: Torvald Riegel <triegel at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 06 Apr 2017 14:27:31 +0200
- Subject: Re: [PATCH 2/2] S390: Use generic spinlock code.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=triegel at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 64C00C04B941
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 64C00C04B941
- References: <1481905917-15654-1-git-send-email-stli@linux.vnet.ibm.com> <1481905917-15654-2-git-send-email-stli@linux.vnet.ibm.com> <e23a27c4-904f-3c1f-f211-fb67b0f8c5a5@linux.vnet.ibm.com> <1487018364.16322.88.camel@redhat.com> <c7954f69-04a0-47f1-7c79-3866d15cfe09@linux.vnet.ibm.com> <1487437519.20203.74.camel@redhat.com> <6910c6f2-b763-e311-88c9-91d774f796e0@linux.vnet.ibm.com>
On Tue, 2017-03-14 at 16:55 +0100, Stefan Liebler wrote:
> On 02/18/2017 06:05 PM, Torvald Riegel wrote:
> > On Wed, 2017-02-15 at 17:26 +0100, Stefan Liebler wrote:
> >> On 02/13/2017 09:39 PM, Torvald Riegel wrote:
> >>> On Wed, 2017-02-08 at 15:49 +0100, Stefan Liebler wrote:
> >>> Also, I'm not quite sure whether this number is really
> >>> spinlock-specific, and I would like to find a better place for these.
> >>> IMO, they should be in some header that contains default tuning
> >>> parameters for synchronization code, which is provided by each
> >>> architecture that uses the generic spinlock; we'd have no #ifdef for the
> >>> tuning parameters, so we'd catch typos in those headers.
> >>>
> >> See pthread_spin_parameters.h in updated patch 1/2.
> >
> > I suggest that we'll work towards consensus on patch 1/2 first. I
> > believe once that is done, patch 2/2 would likely just remove s390 code.
> >
> I've attached an updated patch which just removes the s390 code.
Okay.