This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Ping! Re: [PATCH v2] rwlock: Fix explicit hand-over.
- From: Torvald Riegel <triegel at redhat dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Waiman Long <longman at redhat dot com>, Carlos O'Donell <codonell at redhat dot com>
- Date: Thu, 06 Apr 2017 12:51:44 +0200
- Subject: Ping! Re: [PATCH v2] rwlock: Fix explicit hand-over.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=triegel at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9CEAE800
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9CEAE800
- References: <1490471341.26906.366.camel@redhat.com> <87inmxkt67.fsf@mid.deneb.enyo.de> <1490482860.26906.391.camel@redhat.com>
On Sun, 2017-03-26 at 00:01 +0100, Torvald Riegel wrote:
> On Sat, 2017-03-25 at 21:17 +0100, Florian Weimer wrote:
> > * Torvald Riegel:
> >
> > > + bool registered_while_in_write_phase = false;
> > > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0))
> > > return 0;
> > > + else
> > > + registered_while_in_write_phase = true;
> >
> > Sorry, this doesn't look quite right. Isn't
> > registered_while_in_write_phase always true?
>
> Attached is a v2 patch. It's the same logic, but bigger. Most of this
> increase is due to reformatting, but I also adapted some of the
> comments.
> I get two failures, but I guess these are either due to the bad internet
> connectivity I currently have, or something at the resolver.
> FAIL: resolv/mtrace-tst-leaks
> FAIL: resolv/tst-leaks
>
Ping.