This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3][BZ 21340] add support for POSIX_SPAWN_SETSID
On 5 April 2017 at 18:34, Florian Weimer <fweimer@redhat.com> wrote:
> On 04/05/2017 07:41 AM, daurnimator wrote:
>
>> +static int
>> +do_test (void)
>> +{
>> + posix_spawnattr_t attrp;
>> + int res;
>> + int child_pid;
>> + int sid, child_sid;
>> + char *args[2];
>
>
> Thanks for writing the test. There are some style issues. We prefer
> in-line declarations these days
Do you mean putting 'static int do_test (void) {' on one line?
> and there should be a space before “(” in a
> function call.
There already was?
> Please use the new test skeleton in <support/test-driver.c>. (Sorry, still
> need to update the wiki.)
I just worked from the existing test 'tst-posix_spawn-fd.c'.
> You aren't listed in MAINTAINERS on the wiki. Do you have a GNU copyright
> assignment on file?
I do not.