This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH COMMITTED] nss_dns: Remove superfluous dn_expand call from network handling

From: Florian Weimer <fweimer at redhat dot com>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: libc-alpha at sourceware dot org
Date: Wed, 5 Apr 2017 08:51:31 +0200
Subject: Re: [PATCH COMMITTED] nss_dns: Remove superfluous dn_expand call from network handling
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 298274E359
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 298274E359
References: <20170404190120.E9DD64035F5CB@oldenburg.str.redhat.com> <87efx8kjz0.fsf@linux-m68k.org>

On 04/04/2017 10:15 PM, Andreas Schwab wrote:

On Apr 04 2017, fweimer@redhat.com (Florian Weimer) wrote:

	* resolv/nss_dns/dns-network.c (getanswer_r): Remove __dn_expand
	call whose result is not used.


What about the side effect?


The result buffer is overwritten by the subsequent ns_name_ntop call.

Thanks,
Florian

References:
- [PATCH COMMITTED] nss_dns: Remove superfluous dn_expand call from network handling
  - From: Florian Weimer
- Re: [PATCH COMMITTED] nss_dns: Remove superfluous dn_expand call from network handling
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]