This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add random memcpy test
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 24 Mar 2017 14:49:33 -0700
- Subject: Re: [PATCH v3] Add random memcpy test
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gotplt.org; dkim=none (message not signed) header.d=none;gotplt.org; dmarc=none action=none header.from=caviumnetworks.com;
- References: <139a1878-1b85-1af9-011d-5045bda6fd88@gotplt.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, 2017-03-23 at 19:53 +0530, Siddhesh Poyarekar wrote:
> >
> > ChangeLog:
> > 2017-02-09 Wilco Dijkstra <wdijkstr@arm.com>
> >
> > * benchtests/Makefile (string-benchset): Add memcpy-random.
> > * benchtests/bench-memcpy-random.c: New file.
> Nice, this looks good to me. There may be additional cache effects in
> spec2006 that may make these results different from actual spec2006, but
> it is still a valuable data point, definitely more than the repeated
> copies.
>
> Siddhesh
I think there is a Makefile problem in this patch.
make -C ../src/glibc/benchtests objdir=`pwd` bench
make[1]: Entering directory '/home/ubuntu/sellcey/glibc-
ifunc/src/glibc/benchtests'
make[1]: *** No rule to make target '/home/ubuntu/sellcey/glibc-
ifunc/obj-glibc64/benchtests/bench-memcpy-random.o', needed by
'/home/ubuntu/sellcey/glibc-ifunc/obj-glibc64/benchtests/bench-memcpy-
random'. Stop.
make[1]: Leaving directory '/home/ubuntu/sellcey/glibc-
ifunc/src/glibc/benchtests'
Makefile:16: recipe for target 'bench' failed
make: *** [bench] Error 2