This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Consolidate Linux mmap implementation



On 24/03/2017 14:42, Andreas Schwab wrote:
> On Mär 24 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> +void *
>> +__mmap (void *addr, size_t len, int prot, int flags, int fd, off_t offset)
>> +{
>> +  MMAP_CHECK_PAGE_UNIT
> 
> I think it would be better to define this as a function style macro.
> 
> Andreas.
> 

I do not have preference here, I changed to:

# define MMAP_CHECK_PAGE_UNIT() ...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]