Re: [PATCH] stdlib-bsearch: middle element calculation may overflow

[Mike Frysinger <vapier at gentoo dot org>]

On 17 Mar 2017 00:49, Sergey Senozhatsky wrote:
> On (03/16/17 14:02), Joseph Myers wrote:
> > If this fixes a user-visible bug then the ChangeLog entry needs to include 
> > [BZ #N] referencing the bug filed in Bugzilla (and once the fix is in the 
> > bug needs to be resolved as FIXED with appropriate target milestone set).  
> > Is this bug 2753?  If not, a new bug would need to be filed for it.
> 
> a) um... I assume glibc Bugzilla is located at https://sourceware.org/bugzilla/
> and 2753, thus, is https://sourceware.org/bugzilla/show_bug.cgi?id=2753
> if so, then, yes looks like I'm not the first one to point that out.
> I'm not sure I see Ulrich's "You do not even understand how binary
> searching works, do you?  The sum can never exceed nmemb and nmemb
> obviously fits into an size_t" point. it's a bug.

if you see a comment by Ulrich that looks to be unrelated/off, then you
can probably safely assume it is.  if the bug is open still, then we
usually consider it *now* to be something worth fixing.

sorry for the hassle.
-mike

Attachment: signature.asc
Description: Digital signature