Re: [PATCH] Fix test-errno issues

[Mike Frysinger <vapier at gentoo dot org>]

On 13 Mar 2017 11:21, Adhemerval Zanella wrote:
> This patch fixes multiple issues of test-errno.c (9a56f8718341):
> 
>   - Rename Linux test-errno.c to test-errno-linux.c to avoid build
>     the same source for both tests.
> 
>   - Add a mlock check for 32 bits build running on 64 bits kernels.
>     Althuough man pages states that mlock fails with EINVAL if final
>     address overflows, kernels does not return it for aforementioned
>     condition (it returns ENOMEM instead).  Although it seems to be
>     a kernel issue for compat syscall handling, I think it is worth
>     to still check syscall return and document the behavior.
> 
>   - Initialize option lenght for setsockopt check.

"length"

>  ChangeLog                                  |   8 ++
>  posix/test-errno.c                         |   2 +-
>  sysdeps/unix/sysv/linux/Makefile           |   2 +-
>  sysdeps/unix/sysv/linux/test-errno-linux.c | 176 +++++++++++++++++++++++++++++
>  sysdeps/unix/sysv/linux/test-errno.c       | 142 -----------------------
>  5 files changed, 186 insertions(+), 144 deletions(-)
>  create mode 100644 sysdeps/unix/sysv/linux/test-errno-linux.c
>  delete mode 100644 sysdeps/unix/sysv/linux/test-errno.c

if you use -C -M with send-email, then the diff below would show
a rename+changes instead of one large delete and one large create.
as-is, it's hard to review.

i use this in my ~/.gitconfig:
[alias]
	fp = format-patch -C -M
	se = send-email -C -M

this way `git se` will always include -C -M for me.
-mike

Attachment: signature.asc
Description: Digital signature