This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add ifunc memcpy and memmove for aarch64
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Steve Ellcey <sellcey at caviumnetworks dot com>, Siddhesh Poyarekar <siddhesh at gotplt dot org>, Andrew Pinski <pinskia at gmail dot com>
- Cc: <nd at arm dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 14 Mar 2017 18:45:59 +0000
- Subject: Re: [PATCH] Add ifunc memcpy and memmove for aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <AM5PR0802MB2610A11854986B9A53EBC68783430@AM5PR0802MB2610.eurprd08.prod.outlook.com> <c69e79db-4c42-0a14-dd11-d4825612b351@gotplt.org> <c0e44c88-244d-e327-de4b-02470c3a78cf@linaro.org> <1486509609.2866.59.camel@caviumnetworks.com> <805d8c52-1397-ddd0-71cc-93d019f8a7f2@gotplt.org> <1486598532.2866.66.camel@caviumnetworks.com> <589C4992.10505@arm.com> <CA+=Sn1k7BYS4G1Xwpeteif_JK4tdh0O9wCg9WOez4L=C3hMaYQ@mail.gmail.com> <1486688083.2866.82.camel@caviumnetworks.com> <1487809656.2866.171.camel@caviumnetworks.com> <54d21a51-1156-879c-7847-1b19eaca9b3e@gotplt.org> <1487866836.2866.173.camel@caviumnetworks.com> <eabb56f8-bea6-7375-019e-5a6365120a50@gotplt.org> <1487868166.2866.176.camel@caviumnetworks.com> <da742e76-0702-fb09-a1c3-86aadea5179e@gotplt.org> <1488394091.2866.259.camel@caviumnetworks.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 01/03/17 18:48, Steve Ellcey wrote:
> On Thu, 2017-02-23 at 22:23 +0530, Siddhesh Poyarekar wrote:
>> On Thursday 23 February 2017 10:12 PM, Steve Ellcey wrote:
>>>
>>> Just to be clear, the earlier patch would be this one, right?
>>>
>>> https://sourceware.org/ml/libc-alpha/2017-02/msg00175.html
>> Yes. It does everything necessary to get multiarch enabled and working
>> correctly for kernels that support it. The hwcap_mask feature is
>> something that can be added on top and I can commit to doing that within
>> this release.
>>
>> Siddhesh
>
> Ping. Does anyone have any comments or objections to this patch
> that enables IFUNC on aarch64?
the patch looks ok, with HWCAP in bits/hwcap.h instead of
+/* Needed here until this gets into kernel sources. */
+#ifndef HWCAP_CPUID
+# define HWCAP_CPUID (1 << 11)
+#endif
the hwcap value is not yet in linux v4.10, but already
allocated, if we are committed to this value then i
think it's better to only have it in one place.
you may need to include bis/hwcap.h in some files.
i was not sure if we should wait for this to be in a
linux release, but i guess the value won't change now.
an unrelated issue i was wondering about is how the
upcoming ilp32 ifunc resolver will receive the hwcap
argument: will it only see 32bit (unsigned long hwcap)
or 64 bits (with different ifunc resolver prototype)
and if there is something in this area that needs to
be changed before ifuncs are used.