This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] configure.ac: Avoid empty subexpression in grep

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Alexey Neyman <stilor at att dot net>, libc-alpha at sourceware dot org
Date: Thu, 9 Mar 2017 13:50:43 -0800
Subject: Re: [PATCH] configure.ac: Avoid empty subexpression in grep
Authentication-results: sourceware.org; auth=none
References: <8370e47b-8475-a19d-def9-2cac565eb48c@att.net>

On 03/09/2017 08:12 AM, Alexey Neyman wrote:

-  if $READELF -S conftest.so | grep '\.rel\(a\|\)\.dyn' > /dev/null; then
+  if $READELF -S conftest.so | grep '\.\(rel\|rela\)\.dyn' > /dev/null; then

Neither the old nor the new code is portable, as POSIX does not requiresupport for '\|'. Instead, how about something like this?

if $READELF -S conftest.so | grep -F -e '.rel.dyn' -e '.rela.dyn' >/dev/null; then

Follow-Ups:
- [PATCH v2] configure.ac: Avoid empty subexpression in grep
  - From: Alexey Neyman
- Re: [PATCH] configure.ac: Avoid empty subexpression in grep
  - From: Mike Frysinger

References:
- [PATCH] configure.ac: Avoid empty subexpression in grep
  - From: Alexey Neyman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]