This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: 2.25 freeze status
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 27 Jan 2017 09:57:03 -0800
- Subject: Re: 2.25 freeze status
- Authentication-results: sourceware.org; auth=none
- References: <c4cfc6e1-ff9f-c8b3-4a56-38f8d484aa05@gotplt.org>
On Thu, Jan 26, 2017 at 8:06 PM, Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> Hi,
>
> The release date of 1 Feb is upon us and there are 3 release blockers
> that haven't been resolved yet:
>
> - global-dynamic TLS broken on aarch64 and others
> - Fix for bug 20019 causes linker errors for shared libraries using
> longjmp
> - tunables: insecure environment variables passed to subprocesses with
> AT_SECURE
>
> I've got the tunables one and I hope to post a patch by tonight, latest
> by tomorrow morning. What is the status on the other two?
>
> Also, assuming that these fixes go in next week, would arch maintainers
> like another week to run a final set of tests before I cut the release
> branch? If not then I'll simply cut the release 2 days after the
> release blockers are resolved. If yes then I'll cut the release 7 days
> after the current release blockers are resolved.
>
> Does that sound good?
>
> Siddhesh
I am testing this patch for
https://sourceware.org/bugzilla/show_bug.cgi?id=21081
I'd like to check it in before code freeze.
--
H.J.
From 9097edb85e04c137f226f3d371afff34a4ab17b7 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 24 Jan 2017 15:58:49 -0800
Subject: [PATCH] Add VZEROUPPER to memset-vec-unaligned-erms.S [BZ #21081]
Since memset-vec-unaligned-erms.S has VDUP_TO_VEC0_AND_SET_RETURN at
function entry, memset optimized for AVX2 and AVX512 will always use
ymm/zmm register. VZEROUPPER should be placed before ret in
L(stosb):
movq %rdx, %rcx
movzbl %sil, %eax
movq %rdi, %rdx
rep stosb
movq %rdx, %rax
ret
since it can be reached from
L(stosb_more_2x_vec):
cmpq $REP_STOSB_THRESHOLD, %rdx
ja L(stosb)
[BZ #21081]
* sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
(L(stosb)): Add VZEROUPPER before ret.
---
sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
index ff214f0..704eed9 100644
--- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
+++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
@@ -110,6 +110,8 @@ ENTRY (__memset_erms)
ENTRY (MEMSET_SYMBOL (__memset, erms))
# endif
L(stosb):
+ /* Issue vzeroupper before rep stosb. */
+ VZEROUPPER
movq %rdx, %rcx
movzbl %sil, %eax
movq %rdi, %rdx
--
2.9.3