Re: [PATCH] Rework -fno-omit-frame-pointer support on i386

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 09/01/2017 17:02, Nix wrote:
> On 9 Jan 2017, Adhemerval Zanella stated:
> 
>>  ifeq ($(subdir),misc)
>>  sysdep_routines += ioperm iopl vm86
>> -CFLAGS-epoll_pwait.o += $(uses-6-syscall-arguments)
>> -CFLAGS-epoll_pwait.os += $(uses-6-syscall-arguments)
>> -CFLAGS-mmap.o += $(uses-6-syscall-arguments)
>> -CFLAGS-mmap.os += $(uses-6-syscall-arguments)
>> -CFLAGS-mmap64.o += $(uses-6-syscall-arguments)
>> -CFLAGS-mmap64.os += $(uses-6-syscall-arguments)
>> -CFLAGS-pselect.o += $(uses-6-syscall-arguments)
>> -CFLAGS-pselect.os += $(uses-6-syscall-arguments)
>> -CFLAGS-rtld-mmap.os += $(uses-6-syscall-arguments)
>> -endif
> 
> Nice!
> 
>> diff --git a/sysdeps/unix/sysv/linux/i386/configure.ac b/sysdeps/unix/sysv/linux/i386/configure.ac
>> index 1a11da6..06ccb7b 100644
>> --- a/sysdeps/unix/sysv/linux/i386/configure.ac
>> +++ b/sysdeps/unix/sysv/linux/i386/configure.ac
>> @@ -3,5 +3,24 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
>>  
>>  arch_minimum_kernel=2.6.32
>>  
>> +# Check if CFLAGS sets -fno-omit-frame-pointer
>> +AC_CACHE_CHECK(for if compiler flags sets -fno-omit-frame-pointer,
> 
> Perhaps "for -fno-omit-frame-pointer in CFLAGS" might read better.

Indeed, I changed it locally.