This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v11] Add pretty printers for the NPTL lock types
- From: Martin Galvan <omgalvan dot 86 at gmail dot com>
- To: libc-alpha at sourceware dot org, siddesh at sourceware dot org, joseph at codesourcery dot com, triegel at redhat dot com
- Date: Mon, 2 Jan 2017 11:35:14 -0300
- Subject: Re: [PATCH v11] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1701021347590.28945@digraph.polyomino.org.uk>
2017-01-02 10:51 GMT-03:00 Joseph Myers <joseph@codesourcery.com>:
> I'm seeing the following failures with current sources on x86_64. This is
> with system GDB on Ubuntu 16.04 (but a locally built compiler, configured
> as a cross compiler, for building glibc).
Yes, I'm seeing those too. They seem to be caused by a tabs/spaces mismatch introduced in commit ed19993b5b0d05d62cc883571519a67dae481a14.
The following patch should fix it:
ChangeLog:
2017-01-02 Martin Galvan <martingalvan@sourceware.org>
* nptl/nptl-printers.py: Fix tabs/spaces mismatches.
---
nptl/nptl-printers.py | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/nptl/nptl-printers.py b/nptl/nptl-printers.py
index 17463c4..77018e7 100644
--- a/nptl/nptl-printers.py
+++ b/nptl/nptl-printers.py
@@ -348,10 +348,10 @@ class ConditionVariablePrinter(object):
def read_attributes(self):
"""Read the condvar's attributes."""
- if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0:
- self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
- else:
- self.values.append(('Clock ID', 'CLOCK_REALTIME'))
+ if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0:
+ self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
+ else:
+ self.values.append(('Clock ID', 'CLOCK_REALTIME'))
if (self.wrefs & PTHREAD_COND_SHARED_MASK) != 0:
self.values.append(('Shared', 'Yes'))
@@ -409,10 +409,10 @@ class ConditionVariableAttributesPrinter(object):
clock_id = (self.condattr >> 1) & ((1 << COND_CLOCK_BITS) - 1)
- if clock_id != 0:
- self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
- else:
- self.values.append(('Clock ID', 'CLOCK_REALTIME'))
+ if clock_id != 0:
+ self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
+ else:
+ self.values.append(('Clock ID', 'CLOCK_REALTIME'))
if self.condattr & 1:
self.values.append(('Shared', 'Yes'))
--
2.7.4