This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Add framework for tunables
- From: Florian Weimer <fweimer at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org
- Cc: carlos at redhat dot com
- Date: Sat, 31 Dec 2016 17:49:06 +0100
- Subject: Re: [PATCH 1/4] Add framework for tunables
- Authentication-results: sourceware.org; auth=none
- References: <1483198831-2232-1-git-send-email-siddhesh@sourceware.org> <1483198831-2232-2-git-send-email-siddhesh@sourceware.org>
On 12/31/2016 04:40 PM, Siddhesh Poyarekar wrote:
+#ifndef _TUNABLES_H_
+#define _TUNABLES_H_
+
+# if !HAVE_TUNABLES
+static inline void
+__always_inline
+__tunables_init (char **unused __attribute_unused)
+{
+ return;
+}
You can drop the return statement. Maybe replace it with a comment
indicating that this initalization function is optimized out if tunables
are not enabled?
+# else
+
+# include <stddef.h>
+# include "dl-tunable-types.h"
+
+/* A tunable. */
I think the header inclusion guard does not usually trigger such
indentation.
Apart from that, I think the series is ready commit. I will do some
installation-tree testing after that.
Thanks,
Florian