This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix pretty printer tests for run-built-tests == no
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Wed, 28 Dec 2016 20:15:21 -0200
- Subject: Re: [PATCH] Fix pretty printer tests for run-built-tests == no
- Authentication-results: sourceware.org; auth=none
- References: <1482805594-29119-1-git-send-email-siddhesh@sourceware.org>
LGTM, I have hit this issue and I was about to investigate. Thanks for
checking on it.
On 27/12/2016 00:26, Siddhesh Poyarekar wrote:
> In my change to add configure tests for python I had a brainfart where
> I tried to filter out unsupported tests from tests-printers-programs
> instead of tests-printers to select tests to build. I realize now
> that all of that is completely unnecessary and it would be safe to
> just build the tests as long as we don't try to run it.
>
> This patch reverts that bit of the change. Tested with
> run-built-tests = no in config.make.
>
> * Rules (tests): Add tests-printers-programs to tests to be
> built.
> ---
> Rules | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Rules b/Rules
> index 558924d..3195f59 100644
> --- a/Rules
> +++ b/Rules
> @@ -129,9 +129,9 @@ endif
> others: $(py-const)
>
> ifeq ($(run-built-tests),no)
> -tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests) \
> - $(tests-printers-programs)) \
> - $(test-srcs)) $(tests-special)
> +tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests)) \
> + $(test-srcs)) $(tests-special) \
> + $(tests-printers-programs)
> xtests: tests $(xtests-special)
> else
> tests: $(tests:%=$(objpfx)%.out) $(tests-special) $(tests-printers-out)
>